Missing OnNodeExit() Call on conditional node abort

[ijisthee]

Above

schema/Runtime/Proc/ExecutableNode.cs

Line 320 in 3bc87e4

return parent;

action.OnNodeExit(nodeMemory[id], context.agent);

should be called.

If this does not happen, cleanup or update tasks cannot run if after a conditional evaluation the node is aborted.

[ijisthee]

@acdamiani Is this possible to fix or is the current way to do it by design and should not be done differently?

[ijisthee]

Here a proposal that works for me. Maybe you could find a better implementation:

if (context.last.index != index || forceConditionalEvaluation)
    run = DoConditionalStack(id, context);

if (!run)
{
    context.status = NodeStatus.Failure;
    if (context.node.node is Action actionToAbort)
    {
        actionToAbort.OnNodeExit(nodeMemory[id], context.agent);
    }

    return parent;
}

[ijisthee]

reviewed #25