Bk/refactor/base entities #38
Conversation
use new fields provided by datasource model, remove old ones
use single data source object for all base entities, use correct use fields for data source and property model
|
Great that there is another PR! I wanted to try to run the script but realised the Zotero variables were still missing, so would have had to manually force a redeployment... |
|
PR size is so much better, thx! Constructive criticism re: the file deletion commit – in a case like this where a file is replaced/becomes redundant, the deletion is ideally committed simultaneously with the replacement file/changes. For misc. removals of redundant, leftover, old stuff n cruft, I'd be very direct and to the point about that in the summary/subject line and put explanations or further details in the commit body instead. I'll merge these as-is now as I noticed the two deployment branches have diverged, so |
@koeaw: pull request should be small enough. please report back, if not