Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differ between conceptScheme identifier and base-URI #58

Closed
KlausIllmayer opened this issue Dec 13, 2022 · 4 comments · Fixed by #62
Closed

Differ between conceptScheme identifier and base-URI #58

KlausIllmayer opened this issue Dec 13, 2022 · 4 comments · Fixed by #62
Assignees
Labels
question Further information is requested

Comments

@KlausIllmayer
Copy link

Currently, the identifier of the conceptScheme also acts as base-URI for concepts without legacy id. If you do an export of a conceptScheme it will generate concept-URIs based on the identifier of the conceptScheme and additional the /concept[id] appendix. This is problematic, as the identifier of the conceptScheme must not be the base-URI. There are different approaches in place and they currently do have a direct unwanted effect on the concept-URIs. Sometimes, the conceptScheme has a dedicated URI, e.g. https://example.com/vocabulary/Scheme or it has a trailing slash at the end, e.g. https://example.com/vocabulary/. In the current setup this leads to concepts that in the first case have a uri https://example.com/vocabulary/Scheme/concept1234 and in the second case a URI https://example.com/vocabulary//concept1234 (two slashes in-between). Both is not expected, instead we like to be able to have a base-URI and additionally the possibility of a dedicated different conceptScheme-URI.

The current workaround is to have the identifier of the conceptScheme as baseURI without a trailing slash, e.g. https://example.com/vocabulary and use the legacyId field of the conceptScheme for the identifier of the conceptScheme, e.g. https://example.com/vocabulary/ or https://example.com/vocabulary/Scheme. That is not optimal and you need to be aware about this workaround. Could we think about a different approach, that makes it more clear to users, like a a dedicated field baseURI in the conceptScheme definition, that acts for the generation of all other URIs and an identifier-appendix field for the conceptScheme itself? @csae8092 what is your opinion on this and how is this complicating things?

@KlausIllmayer KlausIllmayer added the question Further information is requested label Dec 13, 2022
@KlausIllmayer
Copy link
Author

Okay, I should have tested my workaround beforehand. It seems that legacyId is ignored in case of conceptScheme - will need to file an issue on this. But this makes the issue more urgent.

@csae8092
Copy link
Member

@KlausIllmayer
Copy link
Author

Thanks for solving, one issue is left (and it seems we didn't tested it): when there is a concept-scheme without legacy-id it now creates empty values for the concept properteis inScheme and topConceptOf (could be that the last addition - getting rid of // - may have introduced this issue)

@KlausIllmayer KlausIllmayer reopened this Dec 20, 2022
@KlausIllmayer
Copy link
Author

fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants