Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to version 0.3.3 from the original repo + a bugfix for issue #74 at Google Code's issue tracker #1

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

Update to version 0.3.3 from the original repo + a bugfix for issue #74 at Google Code's issue tracker #1

wants to merge 97 commits into from

Conversation

boris-chervenkov
Copy link

No description provided.

(no author) and others added 30 commits February 17, 2009 20:45
Initial directory structure.
7fdd87e 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@1 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Initial source and metadata import.
5210e14 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@2 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Added missing management command files.
396ffe9 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@3 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Temporary patch for resolving NotRegistered bug.
5cf8903 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@9 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Added docs and implementation for the translation registry.
6fe1f79 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@10 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Fixed the management command for updating translation fields.
2be0504 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@11 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Updated documentation.
d57f851 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@14 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Mostly cleanup.
54e930f 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@15 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Updated documentation and added some initial distutils setup file.
73a9ece 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@18 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Prepared 0.1 release.
fa51b26 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@19 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@peschler
Admin code cleanup (fixes issue 3).
cb9c9bd 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@20 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for inlines.
2fab51b 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@21 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Resolved acdha#1 (thanks to carl.j.meyer for the patch).
805228e 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@22 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed tests to run from any project, resolving #6 (thanks to carl.j.m…
d657aee 
…eyer).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@23 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed creation of db fields with invalid python language code, resolv…
a68e366 
…ing #4 (thanks to carl.j.meyer).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@24 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for South, resolves issue 11 (thanks to andrewgodwin).
03da149 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@25 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed broken admin fields and fieldsets. Resolves issue 9 (thanks to …
4026600 
…simoncelen).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@26 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Removed print statements so its usable with mod_wsgi. Resolves issue 7.
be6a95a 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@27 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Removed TRANSLATION_REGISTRY setting. The translation.py is supposed …
348adb4 
…to be kept in the project root and this has to be in PYTHONPATH anyway.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@28 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Only print debug statements to stdout if the runserver or runserver_p…
7127c04 
…lus management commands are used. Resolves issue 16.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@29 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Code cleanups.
058093a 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@30 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for generic admin inlines (GenericTabularInline, Generi…
805d596 
…cStackedInline). Factored out patch_translation_field functionality and import cleanups.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@31 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added workaround for swallowed ImportErrors by printing a traceback e…
349f891 
…xplicitly. Mostly resolves issue 17.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@32 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed occasional "This field is required" error for the original fiel…
f786440 
…d. Resolves issue 5.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@33 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Preserve the formfield widget of the translated field (thanks to piqu…
4da785c 
…adrat).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@34 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Reverted removal of TRANSLATION_REGISTRY. Handled ImportError.
4ef4369 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@35 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Resolved a race condition between model import and translation regist…
b51f383 
…ration in production by ensuring that models are registered for translation before TranslationAdmin runs. Resolves issue 19 (thanks to carl.j.meyer).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@36 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Updated changelog.
804cf85 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@37 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for admin list_editable. Resolves issue 20 (thanks to c…
20d88a5 
…arl.j.meyer).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@38 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for admin prepopulated_fields. Resolves issue 21.
c585d94 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@39 eb01185e-fd33-11dd-bc25-5f29055a2a2d
deschler and others added 26 commits September 29, 2010 10:19
@deschler
Ensured dict names are unique on a model-app-fieldname basis.
dab9c5d 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@99 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added (incomplete) list of contributors to authors file.
54d3cda 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@100 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed translations are not saved for tinymce HTMLField when using jqu…
391f3ea 
…ery tabs. Resolves issue (thanks to kottenator).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@101 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added changelog message for resolved issue 5.
c86e593 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@102 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed a bug in the admin integration where an emptied default languag…
b85c5ea 
…e field (which has been defined with "blank=True") hasn't cleared the default field. Resolves issue 47.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@103 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Made the section "TranslationAdmin in combination with other admin cl…
6afb724 
…asses" less confusing. Resolves issue 32.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@104 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added FIXED for issue 47.
123a5be 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@106 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Removed unused import which even breaks django-1.3 support.
2a788d0 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@107 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added basic model inheritance tests (test_multitable_inheritance curr…
bb59e47 
…ently fails until the support is fixed in modeltranslation).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@108 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added additional meta-data.
d05de92 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@109 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added download url.
dc0b948 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@110 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Added support for multi-table inheritance. Resolves issues 50 and 51 …
46eafcd 
…(thanks to Sébastien Fievet).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@111 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Prepared docs for 0.3 release.
ec8a753 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@112 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Bumped version to 0.3.
4843c45 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@113 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Created 0.3 docs from current development version.
e5b98ae 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@119 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Renamed media folder to static.
c033939 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@120 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Bumped version to 0.3.1.
8a373c9 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@121 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed static files not included during installation. Resolves reopene…
73c202d 
…d issue 61 (thanks to Chris Adams).

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@122 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed tabs don't properly support two-part language codes. Resolves i…
152466c 
…ssue 63.

git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@123 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Fixed grouped fieldsets translation is not displayed. Resolves issue 52.
333bd6e 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@124 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@deschler
Reverted r123 as this leads to problems with inlines.
b0c3f54 
git-svn-id: http://django-modeltranslation.googlecode.com/svn/trunk@125 eb01185e-fd33-11dd-bc25-5f29055a2a2d
@acdha
Change jQuery search path
969bfee 
This allows use of a version of jQuery other than the one provided by Django.
Users who want to force the use of Django's jQuery can include force_jquery.js
@acdha
setup.py: ensure static directory contents are installed
cd0f373
Updated to version 0.3.3 from the original repository at Google Code
fe60365 
http://code.google.com/p/django-modeltranslation
Fixes #74 - Widgets for translated fields are not properly copied fro…
5f9dec4 
…m original fields

http://code.google.com/p/django-modeltranslation/issues/detail?id=74&sort=-id

Steps to reproduce the problem:
1. Add several char fields to a model with different lengths and mark them for translation
2. Go to the admin, and all field inputs will have the attributes of the last field in the admin - most notably maxlength="..."

The problem is that when you're copying the widget from the original field, "copy.copy" is used.
"copy" does not copy the attrs dictionary, but rather sets a reference to the dict of the original widget.
Since Django admin uses one widget instance for all Charfields, all char fields get the attrs of the last field's widget.

"deepcopy"must be used instead - then everything works correctly.

Patch:

modeltranslation/admin.py - line 44 - TranslationAdminBase.patch_translation_field(...)

44:            field.widget = copy(orig_formfield.widget)

must become

44:            field.widget = deepcopy(orig_formfield.widget)
Added gitignore for python files
a01ab7f
@acdha
Copy link
Owner

acdha commented May 7, 2012

I'm not a maintainer on the upstream project so I'd prefer to discuss changes over in http://groups.google.com/group/django-modeltranslation and perhaps interest the project owners in switching to Github.

That said, this is a very good simply change but I'd prefer to only pull in 5f9dec4 - normally that should be in a branch independent of other changes but since this is so simple I just cherry-picked it in after doing a git svn rebase against the upstream Google Code project.

@acdha
Copy link
Owner

acdha commented Nov 14, 2012

@boris-chervenkov: I've reset my git-svn fork to follow @deschler's official repository. This will unfortunately completely break your pull request – my apologies for the hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@boris-chervenkov @acdha @peschler @deschler