Don't update if unchanged #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IcanDivideBy0
suggested changes
May 14, 2017
src/index.js
Outdated
| @@ -4,6 +4,12 @@ import React from 'react'; | |||
| import Markdown from 'remarkable'; | |||
|
|
|||
| var Remarkable = React.createClass({ | |||
| propTypes: { | |||
| container: React.PropTypes.string, | |||
There was a problem hiding this comment.
I know the PR getting old, but accessing PropTypes from the main React package is deprecated now.
Empact
force-pushed
the
dont-update-if-unchanged
branch
from
98aa486
to
f702f8a
Compare
|
Mind rebasing the changes? Thanks! |
Empact
force-pushed
the
dont-update-if-unchanged
branch
from
f702f8a
to
c5b5bb1
Compare
If there are no children, then the output could not have changed in this case.
This case is equivalent to the unchanged source case.
Empact
force-pushed
the
dont-update-if-unchanged
branch
from
c5b5bb1
to
1214e3c
Compare
|
Done - note I haven't tested this recently so would be good to test it out! |
Empact
force-pushed
the
dont-update-if-unchanged
branch
from
39b9f38
to
8259b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of cases in which the contents are re-rendered, specifically handling the
sourcecontent case and the single unchanged string child case.