-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update missing deps (standalone examples) #71
Conversation
"dependencies": { | ||
"history": "^1.9.1", | ||
"react": "^0.14.0-rc1", | ||
"react-dom": "^0.14.0-rc1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really only work with React 0.14?
@AsaAyers it works if you wrap about 'redux' yes, it depend on it right here: about peerDependency, I'm unfamiliar with it. |
If it is a If instead, it were a The 3rd option is to just not specify that dependency. It currently works because my project's dependencies will install a version of |
I see. |
I'd leave that up to the owners here to decide, but that's the option I think I'd chose. I haven't upgraded to npm@3 yet, so this is based on my experience with npm@2 and what I have read about the upcoming changes. Either way, I think it's outside the scope of this PR, which just updates the example app |
We experimented with |
currently missing dependencies taken from the main repository.
this PR fix this by explicitly specify deps in examples/package.json