Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-colon causes the diff to insert incorrectly #31

Closed
lofty-ometis opened this issue Mar 19, 2018 · 3 comments
Closed

Semi-colon causes the diff to insert incorrectly #31

lofty-ometis opened this issue Mar 19, 2018 · 3 comments

Comments

@lofty-ometis
Copy link

In the first attached image the semi-colon on the right seems to be causing an issue.
The semi-colon only exists in the right pane, where-as in the left pane it exists further down after some further parameters have been added. The code therefore wants to insert the additional code from the left-pane above the code on the right, but it should include and replace the bottom line on the right.
chrome_2018-03-19_16-55-49

This second attachment shows what I'd expect to happen. I've simply replaced the semi-colon with another random charcter '>' to prove my point:
chrome_2018-03-19_16-59-02

Please can you help me with escaping semi-colons or suggest a fix?

@lofty-ometis lofty-ometis changed the title Semi-colon causes the diff to Semi-colon causes the diff to insert incorrectly Mar 19, 2018
@JackuB
Copy link
Collaborator

JackuB commented Apr 19, 2018

@lofty-ometis could you please paste here the strings in editors so I could debug them? At least the offending part.

@lofty-ometis
Copy link
Author

Hi,
I realised that it may not be an issue with your package but that it doesn't support the language (Qlik) I was hoping to use it for.

Do you intend to make it easily adaptable for other languages?

Thanks.

@JackuB
Copy link
Collaborator

JackuB commented May 3, 2018

@lofty-ometis ace-diff is language independent - you can just specify the Mode with the ace-diff API https://github.com/ace-diff/ace-diff#diffing-settings

@JackuB JackuB closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants