-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect highlighting #53
Comments
Did you find solution? |
Unfortunately I have not found solution. Too many ace specific and ace-diff specific moments have been found. I use ace v1.2.6 |
Don't have an example to repro, but a bunch of similar issues were solved by PR #69 - closing this one as well. Feel free to reopen |
Same issue here. Is there a plan when the fix could be merged? |
It seems like this is still an issue and something I am running into trying to implement this. It doesn't seem to handle nested XML documents very well. Most times the change highlighting is off by a line or incorrect by a decent margin. Example below using the demo website using the latest versions. I used a demo page off the diff-match-patch to sort of see what the underlying diff could look like and it seems to generate the diff correctly. https://neil.fraser.name/software/diff_match_patch/demos/diff.html It appears as though ( just a guess ), that something is not working correctly with the visualization portions in some cases. Has anyone else run into this and found a working solution ? I'm not sure if there's any plans to update this library, but I may have to look into a different solution for my use case if not. |
I have 2 version of a code with one different value of var:
left:
right:
The diff is in left.copyLinkEnabled, left code has
false
, right hastrue
but ace-diff marks the next line of the editors like it has the diff. Where is the issue?The text was updated successfully, but these errors were encountered: