Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: font sizes belong to settings.py #84

Closed
surak opened this issue Feb 29, 2020 · 4 comments
Closed

Suggestion: font sizes belong to settings.py #84

surak opened this issue Feb 29, 2020 · 4 comments
Assignees
Labels
on hold Currently on hold, will be worked on soon

Comments

@surak
Copy link
Contributor

surak commented Feb 29, 2020

I have the calendar in a corner, and my vision is not that sharp as it used to be. Plus, our font rendering is not optimal.

Because of that, I use bigger fonts... And this configuration belongs to the settings, no?

@aceisace
Copy link
Member

aceisace commented Mar 1, 2020

@surak Hi surak, thanks for this sugegstion.

The idea was that:

  • Required settings belong to settings.py (change via web-ui)
  • Optional settings belong to configuration.py (change manually, for advanced users only)

As the fontisze for each module isn't strictly required, fontsizes are found and set in configuration.py.

But I'd like to know the opinion of @vitasam and @Atrejoe on this regard.

@aceisace aceisace self-assigned this Mar 1, 2020
@aceisace aceisace added the on hold Currently on hold, will be worked on soon label Apr 3, 2020
@aceisace
Copy link
Member

aceisace commented Apr 3, 2020

Will work on this once the situation gets better, apologies for the delay.

@aceisace
Copy link
Member

@surak
Hi, the new release will have classes with configurable options (inkycal_weather.fontsize = 13). The configuration.py will not exist anymore. Any configuration belonging to a module should be set by that module. This will be a step to a more maintainable code.

A few improvements regarding the rendering of text are also underway, so hopefully there will be some more improvements to look forward to.

@aceisace
Copy link
Member

Closing this issue due to refactoring of the software (see /dev_v2 branch). If you feel a need to re-open this issue, please feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Currently on hold, will be worked on soon
Projects
None yet
Development

No branches or pull requests

2 participants