Tab doesn't cycle between sets after update

[fcFn]

After updating to 3.7, pressing Tab no longer cycles between sets, instead "File is read-only" is displayed. Tested on a fresh install of GoLand 2020.3.4 with default settings and bundled plugins only.

To Reproduce

1. Open a file spanning more than one screen.
2. Press Ctrl+;.
3. Enter the search string that is found across multiple screens.
4. Press the Tab key.

Expected behavior

The next set of results is displayed.

Desktop:

• OS: Windows 10
• IDE: GoLand 2020.3.4
• AceJump version: 3.7

[breandan]

Currently, you can only use Enter and Shift+Enter to cycle through the individual results. I believe this Tab and Shift+Tab scrolling functionality was removed to simplify refactoring and pressing tab was intentionally disabled in #353. Previously, as you mentioned, this calculated the middle of the next/previous set of matches and centered them on the screen. If you rely on this functionality, you can roll back to 3.6.3 until it can be reimplemented. Thank you for the reminder. cc: @chylex

[fcFn]

Thank you, perhaps the README should be updated until this functionality is back.

[chylex]

Yep, sorry I forgot to remind you that this feature was missing. It's still possible to use Page Up/Down or use other IJ/GO scrolling actions if that works for you, but of course the original functionality of jumping past areas with no tags was more convenient than normal IJ/GO scrolling.

[Skorpionos]

Additional to this "Enter" and "Shift+Enter" do not work too

[breandan]

This regression should be fixed in the next update, 3.8.5. I'd like to look at #380 and release these two together.

[breandan]

This should now be available in AceJump 3.8.5. Feel free to give it a try and let us know if you have any issues.

[fcFn]

Installed 3.8.5 and still get "File is read-only" upon pressing Tab.

UPD: This only happens when your cursor is inside text into which a language was injected (for example, an SQL query inside a JS file). Moving the cursor out of the portion with injected language makes cycling with Tab work and will show results inside the injected portion as well. Uninjecting the language also makes Tab cycling work when the cursor is inside the previously injected text.