Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround tag misalignment on high DPI screens #384

Merged
merged 2 commits into from Nov 14, 2021
Merged

Conversation

chylex
Copy link
Collaborator

@chylex chylex commented Nov 14, 2021

Fixes #362.

I don't know a "proper" solution, but imo it's better than the constant eyesore :P
Also fixes the text highlighter background starting one pixel too low.

OS DPI Retina Result
Windows = 100% OK
> 100% A hot mess both before and after this change. I'd say anyone who uses Windows on High DPi is already used to it being an utterly terrible experience, so I'm not going to try figure this out.
> 100% OK
Linux (KDE) = 100% OK
> 100% OK
Mac OS = 100% OK
> 100% N/A (could not set >100% DPI on external monitor)
= 100% N/A (could not set 100% DPI on Retina)
> 100% OK

@chylex
Copy link
Collaborator Author

chylex commented Nov 14, 2021

Also @breandan, can you please change the attribution in README to my username instead of full name? I can add it to this PR or a separate PR if you want.

@breandan
Copy link
Collaborator

Great work @chylex, as usual. Please feel free to add your preferred attribution to this PR. Thanks!

@chylex
Copy link
Collaborator Author

chylex commented Nov 14, 2021

Done.

@breandan breandan merged commit 8d62b0d into acejump:master Nov 14, 2021
@chylex chylex deleted the dpi branch November 14, 2021 21:33
@breandan
Copy link
Collaborator

This should now be released and available to try in 3.8.4. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight offset difference on high-DPI screens
2 participants