Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move status variable updates out of statemachine #6531

Closed
kymckay opened this issue Aug 14, 2018 · 1 comment
Closed

Move status variable updates out of statemachine #6531

kymckay opened this issue Aug 14, 2018 · 1 comment

Comments

@kymckay
Copy link
Member

kymckay commented Aug 14, 2018

Some unit status variables are being updated directly in statemachine transition functions (exiting cardiac arrest resets heart rate, entering death sets it to 0), we should move these into event handlers in either the status or vitals component (whichever is more appropriate).

@kymckay
Copy link
Member Author

kymckay commented Aug 17, 2018

I'm doing this at the moment and actually think it makes the most sense to just call functions in the status component directly (since statemachine is dependent on it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants