Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Rewrite: Extension & wound assignment TODO #6939

Closed
2 of 3 tasks
BaerMitUmlaut opened this issue Apr 13, 2019 · 7 comments
Closed
2 of 3 tasks

Medical Rewrite: Extension & wound assignment TODO #6939

BaerMitUmlaut opened this issue Apr 13, 2019 · 7 comments

Comments

@BaerMitUmlaut
Copy link
Member

BaerMitUmlaut commented Apr 13, 2019

  • Disable extension completely for now
  • Add handling of fractures (causeFracture flag in wound config)
  • Test how far wound assignment can be optimized, benchmark, check if extension is necessary
@dedmen
Copy link
Contributor

dedmen commented Apr 18, 2019

Note for re-enabling extension later on.
If we just try to call it once at preStart so that battleye sees it. They will auto-whitelist the extension if enough people try to load it.
So we could add it one-release before we actually put it to use to make sure it get's whitelisted.

Don't know how it was done in the past, messaging BE asking to whitelist it?

@jonpas
Copy link
Member

jonpas commented Apr 18, 2019

Don't know how it was done in the past, messaging BE asking to whitelist it?

Correct.

@dedmen
Copy link
Contributor

dedmen commented Apr 18, 2019

I heard mostly bad things about BE support recently. So might be worth keeping the other option in mind as a fallback.

@TheMagnetar
Copy link
Member

If we just try to call it once at preStart so that battleye sees it. They will auto-whitelist the extension if enough people try to load it.

That sounds... dangerous?!

@BaerMitUmlaut
Copy link
Member Author

I wouldn't worry about whitelisting, it's automated.

@LinkIsGrim
Copy link
Contributor

Test how far wound assignment can be optimized, benchmark, check if extension is necessary

#8926 optimized a bit. Going back to extension seems problematic now that we support 3rd party wound handling, though.

@jonpas
Copy link
Member

jonpas commented Nov 3, 2023

There is no need for the extension if performance in SQF is good. Some benchmarks would be nice, maybe compared to the old version with extension (if it still works with today's Arma).

Medical Focus Feature automation moved this from Open to Closed Nov 12, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants