Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo - Go over config values again #9964

Open
LinkIsGrim opened this issue Apr 20, 2024 · 2 comments
Open

Cargo - Go over config values again #9964

LinkIsGrim opened this issue Apr 20, 2024 · 2 comments

Comments

@LinkIsGrim
Copy link
Contributor

Cargo refactor changed it so GVAR(hasCargo) needs to be explicit (either through inheritance or just set in class).

Need to go over configs again and make sure that's the case where it should be.

Sizes/spaces are also messed up. Some objects allow for bags of holding: https://github.com/acemod/ACE3/blob/master/addons/cargo/CfgVehicles.hpp#L778-L785

Other have GVAR(hasCargo) set to over 1: https://github.com/acemod/ACE3/blob/master/addons/cargo/CfgVehicles.hpp#L512-L513 should still work, but should just be 1

@johnb432 @Mike-MF @LinkIsGrim

@johnb432
Copy link
Contributor

johnb432 commented Apr 20, 2024

should still work, but should just be 1

No it doesn't, as it checks for 1 specifically.

@johnb432
Copy link
Contributor

Sizes/spaces are also messed up. Some objects allow for bags of holding: https://github.com/acemod/ACE3/blob/master/addons/cargo/CfgVehicles.hpp#L778-L785

I'm fairly confident that's intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants