Remove unused dependencies #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelstrom
force-pushed
the
remove-unused-dependencies
branch
from
220d2b9
to
62e9e25
Compare
This is the version that is generated when running `ember addon NAME`.
The unit tests already run the linter.
We don't need to run `ember test`, which requires ember-cli-babel and ember-source and loads of other stuff. We can just use `yarn test` which is lightweight and appropriate for this addon.
nelstrom
force-pushed
the
remove-unused-dependencies
branch
from
6f12b98
to
52e6c1b
Compare
This file is for configuring https://github.com/shipshapecode/ember-cli-release The addon is deprecated. The README recommends using https://github.com/release-it/release-it
This addon doesn't have any ember specific code in it, so we don't really need to test this addon against different versions of Ember.
|
Thanks for this @nelstrom . You're a ⭐ Would you mind dropping the commit that bumps the version then one that reverts that commit? No point them being there. Other than that, It's good to go. |
nelstrom
force-pushed
the
remove-unused-dependencies
branch
from
5265859
to
45e8358
Compare
|
@achambers done. |
It seems as though ember-cli makes it a hard requirement that ember-cli-babel is available as a preprocessor for .js files. https://github.com/ember-cli/ember-cli/blob/70ae16c5eb972076580b23e9c22579234749862e/lib/models/addon.js#L1308-L1334
achambers
approved these changes
Jun 9, 2021
| "ember-cli-inject-live-reload": "^1.4.0", | ||
| "ember-cli-jshint": "^1.0.0", | ||
| "ember-cli-qunit": "^2.1.0", | ||
| "ember-cli-release": "1.0.0-beta.2", |
There was a problem hiding this comment.
FYI - this addon (and the corresponding config/release.js file) is used for publishing this addon to npm and updating GH releases. However, https://github.com/release-it/release-it is the more modern way of doing this these days and so this repo could probably do with updating to use that. So, we can keep this change for now. Just an FYI.
|
Thanks @nelstrom . Published as https://github.com/achambers/ember-cli-deploy-git-revision-data/releases/tag/v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon was looking quite out of date. In particular, the fact that it depended on
ember-cli-babelversion 5 was starting to cause issues for an Ember app that depends on this addon.These changes are fairly substantial, so I bumped the version from
0.2.0to1.0.0. I don't actually believe that there were any breaking changes, so maybe0.3.0would have been appropriate?Here's a summary of what I changed:
Consolidating dependencies
The main functionality of this addon is implemented in the
index.jsfile. That file has exactly two dependencies:'git-repo-info''ember-cli-deploy-plugin'It makes sense to declare these as
dependenciesin thepackage.jsonfile. That leaves the following asdevDependencies:'chai-as-promised''chai''ember-cli'(required fromember-cli-build.js)'glob''mocha-jshint''mocha'These are mostly used for running unit tests.
Everything else must go! 🔥🔥🔥
Use native Promise instead of RSVP
Node has had Promise API for ages. This addon supports node 10 and later. We don't need RSVP as a polyfill anymore.
Update Travis configuration
The travis configuration was out of date (using node version 4!). I used the current version of ember-cli (
3.26) to generate a scratch addon and copied the.travis.ymlover to this addon, then made tweaks to get it working again.Remove ember-try
ember-try is great for testing addons against different versions of Ember. To use ember try, you have to run tests via
ember test, which in turn requiresember-source,ember-cli-htmlbarsandember-cli-babel(Remember? That was how we got here in the first place!)... I don't think any of that stuff belongs in this addon.I removed the
ember-tryaddon frompackage.jsonand also removed theconfig/ember-try.jsfile.Remove bower
bower looks like a relic from a bygone era. We don't need it.