Fix build by adding /v4 to module path #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achannarasappa
requested changes
Dec 21, 2023
| @@ -1,8 +1,8 @@ | |||
| <p> | |||
| <a href="https://github.com/achannarasappa/ticker/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a> | |||
| <a href="https://github.com/achannarasappa/ticker/actions"><img src="https://github.com/achannarasappa/ticker/workflows/test/badge.svg" alt="Build Status"></a> | |||
| <a href="https://github.com/achannarasappa/ticker/v4/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a> | |||
There was a problem hiding this comment.
URLs in the readme should remain without a /v4/
| @@ -62,7 +62,7 @@ brews: | |||
| commit_author: | |||
| name: achannarasappa | |||
| email: git@ani.dev | |||
| homepage: "https://github.com/achannarasappa/ticker" | |||
| homepage: "https://github.com/achannarasappa/ticker/v4" | |||
There was a problem hiding this comment.
This URL should remain without a /v4/
| @@ -115,7 +115,7 @@ nfpms: | |||
| file_name_template: "{{ .ProjectName }}-{{ .Version }}-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}-{{ .Mips }}{{ end }}" | |||
| builds: | |||
| - build-linux-64 | |||
| homepage: https://github.com/achannarasappa/ticker | |||
| homepage: https://github.com/achannarasappa/ticker/v4 | |||
There was a problem hiding this comment.
This URL should remain without a /v4/
| @@ -15,7 +15,7 @@ builds: | |||
| post: | |||
| - upx "{{ .Path }}" | |||
| ldflags: | |||
| - -s -w -X 'github.com/achannarasappa/ticker/cmd.Version={{.Version}}' | |||
| - -s -w -X 'github.com/achannarasappa/ticker/v4/cmd.Version={{.Version}}' | |||
There was a problem hiding this comment.
Pretty sure these should remain with a /v4/ but not certain. Have you run a test build to confirm this should be here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close:
go installfails #252