-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi arch docker support #83
Merged
achannarasappa
merged 11 commits into
achannarasappa:master
from
junior:Multi-arch_docker_support
Feb 9, 2021
Merged
Multi arch docker support #83
achannarasappa
merged 11 commits into
achannarasappa:master
from
junior:Multi-arch_docker_support
Feb 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes entries to support buildx to allow build on the same image amd64 and arm64 platforms. Ncessary to support Docker on Apple Silicon and Raspberry PI
Includes entries to support buildx to allow build on the same image amd64 and arm64 platforms. Ncessary to support Docker on Apple Silicon and Raspberry PI
# Test tokens - test token for initial test
One Dockerfile for both platforms
include latest tag for multi-arch docker
removed test commented
Thanks for this contribution @junior ! I know there's been a couple other users who've request Apple M1 support so I'm sure they'll appreciate this I'd make a few suggestions:
Also could you describe how you've tested this build and releases properly? |
As requested, reverted back the docker usage from goticker/ticker to achannarasappa/ticker
Thanks for the details - this looks good to me |
This was referenced Feb 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #82
Extends Docker support to Multi-arch images, including linux/amd64 and linux/arm64 platforms, allowing run Ticker on arm, like Docker on Apple Silicon and Docker on Raspberry Pi
Also introduces easy address for docker runs:
docker run -it --rm goticker/ticker -w BTC-USD,AAPL,TSLA
https://hub.docker.com/r/goticker/ticker