Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch docker support #83

Merged

Conversation

junior
Copy link
Contributor

@junior junior commented Feb 8, 2021

Fixes issue #82

Extends Docker support to Multi-arch images, including linux/amd64 and linux/arm64 platforms, allowing run Ticker on arm, like Docker on Apple Silicon and Docker on Raspberry Pi

Also introduces easy address for docker runs:

docker run -it --rm achannarasappa/ticker -w BTC-USD,AAPL,TSLA

docker run -it --rm goticker/ticker -w BTC-USD,AAPL,TSLA

https://hub.docker.com/r/goticker/ticker

Includes entries to support buildx to allow build on the same image amd64 and arm64 platforms.

Ncessary to support Docker on Apple Silicon and Raspberry PI
Includes entries to support buildx to allow build on the same image amd64 and arm64 platforms.

Ncessary to support Docker on Apple Silicon and Raspberry PI
# Test tokens

- test token for initial test
One Dockerfile for both platforms
include latest tag for multi-arch docker
removed test commented
@achannarasappa
Copy link
Owner

Thanks for this contribution @junior ! I know there's been a couple other users who've request Apple M1 support so I'm sure they'll appreciate this

I'd make a few suggestions:

  1. Include a "default" tag with 64bit support and no suffix (still include version suffices)
  2. Retain the original repository (achannarasappa)

Also could you describe how you've tested this build and releases properly?

As requested, reverted back the docker usage from goticker/ticker to achannarasappa/ticker
@junior
Copy link
Contributor Author

junior commented Feb 9, 2021

  1. Include a "default" tag with 64bit support and no suffix (still include version suffices)

The default tag is included, if you run docker run -it --rm achannarasappa/ticker -w BTC-USD,AAPL,TSLA will use the tag latest.

This is a multi-arch docker manifest image, and includes amd64 and arm64 platforms on the same. The image will looks like that:
image

The scripts is generating the server and latest
e.g.:

  • latest
  • 3.0.3
  • 3.0
  • 3

The image templates (3.0.3-amd64 and 3.0.3-arm64v8) are just the image templates of each platform for the docker manifest

  1. Retain the original repository (achannarasappa)

Updated. Please consider to move to a Docker Hub organization in the future. ;)

If you decided to use the goticker in the future, you have full rights as owner of the org.

Also could you describe how you've tested this build and releases properly?

Goreleaser run on my repo with no problems. Manually tested with docker on Intel MacBook Pro, Apple Silicon Mac mini and Raspberry Pi 4.

@achannarasappa
Copy link
Owner

Thanks for the details - this looks good to me

@achannarasappa achannarasappa merged commit a3625ee into achannarasappa:master Feb 9, 2021
@junior junior deleted the Multi-arch_docker_support branch February 9, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants