Update Elixir/OTP and CI #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map key ordering changes in OTP 26. See https://github.com/elixir-lang/elixir/releases/tag/v1.14.4
achedeuzot
reviewed
Jan 31, 2024
| {":// should fail", []}, | ||
| {"://", []}, | ||
| {"ftps://foo.bar/", []}, |
There was a problem hiding this comment.
Maybe move them to valid_urls check so that it's explicit they are accepted now ? :)
achedeuzot
reviewed
Jan 31, 2024
| - run: mix coveralls.github | ||
| - run: mix dialyzer | ||
| - name: Set up Earthly | ||
| uses: earthly/actions-setup@v1 |
There was a problem hiding this comment.
Nice, I was keen on trying out earthly, looks great <3
|
Overall looks good :) If you can maybe just move the |
achedeuzot
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum version of Elixir is bumped up to 1.13,
so that it is guaranteed that
URI.new/1will be available.Maintaining support for Elixir 1.9 would have meant there being no way
of supporting OTP 26 for all Elixir versions (you either need
:http_uri.parse/1or
URI.new/1).OTP 26 support also required a change to the String validator's doctest.
Earthly is introduced in order to run the same versions in dev as in CI.
Currently,
mix credo --strictwill not run as there's a TODO in social security.