Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading spaces in setup.cfg #1

Closed
wants to merge 1 commit into from

Conversation

DavidWittman
Copy link

The leading spaces in setup.cfg cause an error when running setup.py:

$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 34, in <module>
    'pockyt=pockyt.pockyt:main',
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 125, in setup
    dist.parse_config_files()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 390, in parse_config_files
    parser.read(filename)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 305, in read
    self._read(fp, filename)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 546, in _read
    raise e
ConfigParser.ParsingError: File contains parsing errors: setup.cfg
    [line  2]: '    description-file = README.md\n'

This commit removes them.

The leading spaces in setup.cfg cause an error when running setup.py:

```
$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 34, in <module>
    'pockyt=pockyt.pockyt:main',
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 125, in setup
    dist.parse_config_files()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 390, in parse_config_files
    parser.read(filename)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 305, in read
    self._read(fp, filename)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 546, in _read
    raise e
ConfigParser.ParsingError: File contains parsing errors: setup.cfg
	[line  2]: '    description-file = README.md\n'
```

This commit removes them.
@achembarpu
Copy link
Owner

It's installing fine for me - Python 3.4.2, with setuptools (2.1) and pip (1.5.6).
I tried both commands :

$ python setup.py install

and,

$ pip install .

However, since you're getting an error, it clearly is an issue on some system setups.

Does this pull request completely fix it? If so, I'll merge it, since it doesn't cause any harm, either way.

@DavidWittman
Copy link
Author

@arvindch Yes, after removing those leading spaces I was able to install without issue on Python 2.7.6.

@achembarpu
Copy link
Owner

OK, I did some local testing, and it does seems to fix the installation issue.
However, it turns out that a lot of code needs to be changed for it to run on a python2 install, since configparser and urllib work differently.
I've started working on this already - hopefully python2 support is possible.

@achembarpu
Copy link
Owner

Closing this PR now. If any python2 setup incompatibilities persist, do reopen it.

@achembarpu achembarpu closed this Oct 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants