Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

feat: add proxy support #122

Merged
merged 3 commits into from Mar 15, 2023
Merged

feat: add proxy support #122

merged 3 commits into from Mar 15, 2023

Conversation

lss233
Copy link
Contributor

@lss233 lss233 commented Mar 14, 2023 •
edited

Replaced websockets with websocket-client, this close #42

acheong08
acheong08 reviewed Mar 14, 2023
View reviewed changes
Copy link
Owner

@acheong08 acheong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not designed for async it seems and using asyncio.get_event_loop().run_in_executor(Non feels very hacky.

@lss233
Copy link
Contributor Author

lss233 commented Mar 15, 2023 •
edited

You're right, although it works fine on my side, we cannot guarantee some changes will break it in the future.
I re-investigated and found out that we can have ws client by using aiohttp or httpx with ws_proto, would you like to use one of these?

@acheong08
Copy link
Owner

I would prefer aiohttp. Thanks

@lss233 lss233 requested review from acheong08 and removed request for acheong08 March 15, 2023 16:18
@lss233 lss233 mentioned this pull request Mar 15, 2023
Closed
@acheong08 acheong08 merged commit 3b01263 into acheong08:master Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acheong08 acheong08 acheong08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proxy support
2 participants
@lss233 @acheong08