Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valueerror pip not found #127

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

shidevil
Copy link
Contributor

@shidevil shidevil commented Dec 2, 2021

Fixes #67

Works on M1 mac now

Proposed Changes

    exec_ = osp.realpath(exec_)
                if exec_ not in execs:
                    execs.append(exec_)

@achillesrasquinha
Copy link
Owner

Thank you for your contribution.

@achillesrasquinha
Copy link
Owner

Could you rebase it to hotfix instead?

@coveralls
Copy link

coveralls commented Dec 2, 2021

Pull Request Test Coverage Report for Build ba378decbd29f17b12d57f7605e485f00a588804-PR-127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 45.412%

Totals Coverage Status
Change from base Build 1222380708: -0.09%
Covered Lines: 960
Relevant Lines: 2114

💛 - Coveralls

@shidevil shidevil changed the base branch from master to hotfix December 2, 2021 15:45
@shidevil
Copy link
Contributor Author

shidevil commented Dec 2, 2021

Could you rebase it to hotfix instead?

Done

@achillesrasquinha achillesrasquinha merged commit d79b658 into achillesrasquinha:hotfix Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: pip executable not found
3 participants