Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO for 1.0 release #91

Closed
12 tasks done
achow101 opened this issue Jan 6, 2019 · 8 comments
Closed
12 tasks done

TODO for 1.0 release #91

achow101 opened this issue Jan 6, 2019 · 8 comments
Milestone
1.0

Comments

@achow101
Copy link
Member

achow101 commented Jan 6, 2019 •
edited

At some point I would like to start doing proper versioning of HWI and release it as both a library and executable script on PyPi. The following need to be done before I feel comfortable doing this:

  • Separate process_commands from commands.py and have the functions in commands.py take actual arguments
  • Handle all possible errors so that no backtraces are printed
  • Remove any interactiivty and command line prompts (except for --debug). The only thing that should be output is the result. (This may not be possible for Trezor and Keepkey, see Trezor and Keepkey require user interaction #83)
  • Have all devices have implementations for all commands. No NotImplementedErrors
  • Tests for all commands, especially transaction signing (incl. multisig)
  • Manual test for ledger
  • Manual Automated test for bitbox
  • Automated test for keepkey
  • Move to bitcoin-core org
  • Deterministic binary and archive builds
  • --version option
  • Whatever else is listed in the 1.0 milestone
@achow101 achow101 mentioned this issue Jan 6, 2019
Merged
@instagibbs
Copy link
Collaborator

Just food for thought: It might also make sense to move this repo into some organization, and establish contributor guidelines/review process going forward.

@achow101
Copy link
Member Author

achow101 commented Jan 7, 2019 •
edited

Since the main goal of this project is to get hardware wallet support into Core, we could see if this can be moved under the bitcoin-core org. I'll bring that up in the next IRC meeting.

achow101 added a commit that referenced this issue Jan 21, 2019
@achow101
Merge #93: Refactor to actually be useful as a library
bd57b8f 
8e4b3fc Add executable script to setup.py and bump version number (Andrew Chow)
2ddd4ed Refactor to make hwilib more like a library (Andrew Chow)

Pull request description:

  Refactors `command.py` so that it just has the functions for each command and the arguments are the actual arguments for the command instead of `args` and `client`. `process_commands` has been moved to `cli.py` along with the handlers that take `args` and `client` which then call the functions in `commands.py` to do the command.

  `setup.py` has been updated to also install a `hwi` executable script and the version number is bumped to 0.0.5.

  This makes HWI actually usable as a library while also having the command line functionality.

  Completes part 1 of #91

Tree-SHA512: 73c36f79b3f28140f1600cd263325d2fffc422b759884bccb613f0ca922d76801973a41fbd52cba0b4142f19f97ac465cfe7277748e4511cadc461f16ba3026c
@instagibbs
Copy link
Collaborator

#121 resolves "* Deterministic binary and archive builds" I presume

@instagibbs
Copy link
Collaborator

I think "* Tests for all commands, especially transaction signing (incl. multisig)" has been covered. Multisig tests have been merged.

@instagibbs
Copy link
Collaborator

is there a tracking issue for --version?

@Sjors
Copy link
Member

Sjors commented Feb 14, 2019

I'd also like #117 in that release as it would allow for library based testing of bitcoin/bitcoin#14912. Although probably I'll need message signing commands too, to double check the import.

@achow101 achow101 added this to the 1.0 milestone Feb 14, 2019
@instagibbs
Copy link
Collaborator

With the -cli limit on transaction sizes(noted in #125) I think we should add #46 to the list so a -cli user can side-step this limitation.

@achow101
Copy link
Member Author

Everything tagged has been merged. I'll tag and publish the release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@Sjors @achow101 @instagibbs