Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPG() parameters to be removed #24

Closed
ecologics opened this issue Oct 22, 2016 · 5 comments
Closed

MPG() parameters to be removed #24

ecologics opened this issue Oct 22, 2016 · 5 comments

Comments

@ecologics
Copy link
Collaborator

ecologics commented Oct 22, 2016

filterPatch and spreadFactor are no longer used, as they were Andrew Fall's parameters.

The first is still useful, but I think it needs to be up to the researcher to prefilter out patches below a threshold number of cells. There is always a danger in helping the user too much! What do you think @achubaty? Too many patches can be hard to interpret. And one cell patches are also of questionable utility and accuracy. Worth implementing?

The second is a legacy option from Andrew Fall and allowed control over how graph was extracted for speed purposes. It could be that variance in Sam's implementation with respect to this variable is leading to differences in resulting graph. Not relevant, so remove.

sa parameter. See discussion in other issue (#23).

@achubaty
Copy link
Owner

filterPatch: will remove, but perhaps we add an example where we pre-filter a raster to show how its done.

spreadFactor: will remove

sa: removed with #23

@ecologics
Copy link
Collaborator Author

Agreed! Example to show how to pre-filter a raster, rather than providing wrapped functionality.

@achubaty
Copy link
Owner

@ecologics I'm about to push the removal. Can you add the example?

@ecologics
Copy link
Collaborator Author

Sure thing. Close this issue, I'll make another one so that I can keep track of what I need to do.

@achubaty
Copy link
Owner

pushed. please reference this issue in the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants