Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement typeable-based default #65

Closed
wants to merge 10 commits into from

Conversation

parsonsmatt
Copy link

@parsonsmatt parsonsmatt commented Jun 12, 2018

This PR implements a Typeable-based default implementation of errorTypeName for better error messages. This implementation uses CPP to preserve GHC < 7.2 compatibility.

Resolves #64

@ddssff
Copy link
Collaborator

ddssff commented Jun 13, 2018

Are we ok with dropping ghc-7.8 support? I am. The travis build is missing typeable instances.

@lemmih
Copy link
Member

lemmih commented Jun 13, 2018

Fine by me.

@parsonsmatt
Copy link
Author

parsonsmatt commented Jun 13, 2018

If we're going to only support >=7.10 then I'll submit a PR without the CPP :)

@ddssff
Copy link
Collaborator

ddssff commented Jun 13, 2018

We should keep 7.10 - some people still use the ghcjs version based on it.

@parsonsmatt
Copy link
Author

OK, it passes CI on GHC >=7.10 :) I regenerated the travis.yml with newer point versions as well (and the newer script), can revert that one if y'all want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errorTypeName method has sensible default implementation
3 participants