SSDT DMAC - FWHD #121
SSDT DMAC - FWHD #121
Conversation
fix ssst-plug to work for all cpu with darwin method so that windows does not undergo changes on cpu power management
add _STA Darwin method to device USBX, IMEI, SBUS, MCHC
fixed space
This reverts commit 4e95f3f.
fix identation
in new intel generations, dmac and fwhd are missing, instead b0d4 is used to correct errors that dsdt has and creates benefit. I propose this addition, of b0d4 I can post the photos of before and after putting it, so you can see it too. thank you
identation fixed
|
which intel generations? what is it trying to fix? |
Docs/AcpiSamples/SSDT-B0D4.dsl
Outdated
|
|
||
| Scope (_SB.PCI0.B0D4) | ||
| { | ||
| If (_OSI ("Darwin")) |
There was a problem hiding this comment.
Some method is missing here.
There was a problem hiding this comment.
there is no lack of method, it is just so. see photo above
There was a problem hiding this comment.
Then how does it work? You cannot return a value from just the scope, it is not a function. Read the ACPI spec.
Docs/AcpiSamples/SSDT-B0D4.dsl
Outdated
| @@ -0,0 +1,16 @@ | |||
| /* | |||
| * Only necessary when B0D4 device is present in the (INTEL) DSDT. | |||
| * For all intel generations, This Configuration Adjust B0D4 device Return (Fix DSDT Warnings and error). | |||
There was a problem hiding this comment.
I still cannot make sense what this SSDT does from the description.
| @@ -0,0 +1,57 @@ | |||
| /* | |||
| * Only necessary when no DMAC device (with any name) is present in the DSDT and a custom device-id | |||
There was a problem hiding this comment.
Why is that device needed? Also not very descriptive to be honest.
| @@ -0,0 +1,35 @@ | |||
| /* | |||
| * Only necessary when no FWHD device (with any name) is present in the DSDT and a custom device-id | |||
|
This needs more background information on what is being done. Both in the PR description and in the dsl tables themselves. |
|
I guess somebody doesn’t even bother reading ACPI speciifications and doesn’t have a clue on coding syntax... |
this one doesn't. Ok
|
Next step? Could you also work on SSDT_SMC? It would help to avoid using a SMC emulator. |
|
It is unjustified why these devices are needed on our machines. Just the fact they are present in Apple ACPI does not make it a requirement for our ACPI. Closing until more information is available. |
ghost
changed the title
This should be said also to Mald0n tbh ._. but hey "APPLE USES THOSE DEVICES SO WE SHOULD INCLUDE THEM WITHOUT ANY KIND OF DOCUMENTATION". Pretty ridiculous |
|
@foskvs @dreamwhite Please refrain from making any comments that do not detail anything about the PR's content, this is not a gossip forum. @Tandem91 That is not how ACPI works. |
in new intel generations, dmac and fwhd are missing.