OcAfterBootCompatLib: Avoid verbose boot overwriting graphics mode #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies - give me a minute - I'm rushing - this doesn't appear to be launching correctly, in modes I tested before uploading it. |
mikebeaton
force-pushed
the
verbose
branch
2 times, most recently
from
1b5d810
to
2974fbb
Compare
|
Redone to use existing code to properly check for -v in nvram or OC provided args. |
mikebeaton
changed the title
sileshn
added a commit
to sileshn/Ryzentosh
that referenced
this pull request
Feb 15, 2023
|
Combining this into #426 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses acidanthera/bugtracker#2225
I believe this is preferable to both the previous and the new behaviour, in that there is no overlap of verbose lines with graphics mode in any circumstance.
I also believe it is preferable to continue to omit the clear screen removed in 2abe076 (which is what is at issue here; NB this visible change is not being caused by a189bd5), as in normal boot progress it is unwanted, and a noticeable slow down on older, slower systems.