Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lilu DeviceInfo detection precludes MacHyperVSupport PCI bridges #2299

Open
flagersgit opened this issue Jun 12, 2023 · 2 comments
Open

Lilu DeviceInfo detection precludes MacHyperVSupport PCI bridges #2299

flagersgit opened this issue Jun 12, 2023 · 2 comments
Labels
help wanted Extra attention is needed project:lilu

Comments

@flagersgit
Copy link

As title mentions, Lilu's DeviceInfo class does not consider MacHyperVSupport PCI bridges.

This is understandably so, because the Hyper-V Gen 2 VM topology is rather weird and nothing alike a normal PC, but nonetheless still problematic.

For example, GPUs (and accompanying HDA) passed to VMs will not have the benefit of patches being applied by WhateverGreen and AppleALC.

@vit9696
Copy link
Contributor

vit9696 commented Jun 12, 2023

Fair enough, but given MacHyperVSupport starts late I really wonder whether we actually can support these. Most likely Lilu will not see these devices. Have you tried to patch Lilu to support this?

@flagersgit
Copy link
Author

flagersgit commented Jun 12, 2023

I haven't tried to patch Lilu yet.

I was considering some approaches to solving this problem.
Perhaps Lilu can route IOPCIBridge::publishNub to see the devices as soon as possible (immediately after they are published children of the HyperVPCIBridge). Will, of course, have to test and see.

EDIT: On second thought, I think even with that, WhateverGreen would still be ahead of the Hyper-V PCI bridge start.

@vit9696 vit9696 added project:lilu help wanted Extra attention is needed labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed project:lilu
Development

No branches or pull requests

2 participants