Merge #36
Merged
Merge #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this commit b0fa50c
When $value is an object then we have to check if it has object vars because according to PHP manual "Objects with no properties are no longer considered empty." http://us1.php.net/manual/en/function.empty.php So is_null($value) when $value is an object it always return false. So the appropriate way to check is using get_object_vars which will return newProp, but the protected and private members will not be returned.
added isset($SID) to tep_href_link so not to provide: Notice: Undefined variable: SID in... I know notices are not shown is osCommerce because of : error_reporting(E_ALL & ~E_NOTICE); but that does not mean that we don't have to check for those.
All images are now responsive to 100% width of their container. Can be turned off by setting parameter to false.
Most images need to be aligned center.
Bootstrapped
…from main product query
Change the tep_get_all_get_params function
tep_not_null update using get_object_vars
Responsive images
Issue #600 obsolete file probably born from an anxious young v3 version
added gloabl $SID to tep_href_link so not to produce: Notice: Undefined variable: SID in...
Include tep_parse_input_field_data into tep_output string_function
added isset($SID) to tep_href_link
added gloabl $SID to tep_href_link
Message Stack
Bug Fix - Account Notifications
Bootstrap Installer
Set the cookie domain when checking for SSL connection
Remove count query in product_info.php and check the total resultset fro...
Use basename instead of strrpos
Move the product model breadcrumb from application top to product_info.php removing a redundant query
avoids +1 query in application top
This reverts commit a2017a5.
If $cPath == 0 in url like this: http://localhost/oscom/product_info.php?cPath=0&products_id=15 bm_categories gives an error
Use basename instead of substr strrpos
Move the product model breadcrumb from application top
Fix bug if $cPath == 0
Revert "Fix bug if $cPath == 0"
Casting int instead to call intval function
Send header "404 not found" when products cannot be found
acidvertigo
added a commit
that referenced
this pull request
Aug 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.