New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: side menu - kaynak butonu twitter yönlendirme sorunu #482 #496
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tweet_id olmasina ragmen burasi yuklenmedi bende, sizde reproducible mi? Su linkten denedim https://deprem-yardim-frontend-git-fork-bb7hn-development-afetharita.vercel.app/#lat=37.588306281721756&lng=36.892022135531754&zoom=16.75 ? Error alert'i de goremedim, reproduce edebilecegim bir URL var mi? |
components/UI/Drawer/Drawer.tsx
Outdated
if (extraParams.user_id && extraParams.tweet_id) { | ||
router.push( | ||
`https://twitter.com/${extraParams.user_id}/status/${extraParams.tweet_id}` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getTwitterLink tarzı bi util mi yazsak? google maps linkinde olduğu gibi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyuser
direkt kullanılabilinir bu arada burada. user id belirtilmeye gerek yok diye biliyorum. Önceki halide zaten bu şekilde çalışıyordu.
@bb7hn Bunu fix ettik mi yoksa bilerek mi yaptik ? |
let extraParams: undefined | ExtraParameters; | ||
|
||
try { | ||
extraParams = JSON.parse(source.extra_parameters || "undefined"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catch ettigimizde de undefined
atayabilir miydik?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kaynak linkine yönlendirme yaparken twitter iframe yüklenmesine rağmen link gitmiyordu.
Normalde endpointte channel gelirken açılmama sebebi channel gelmemesiymiş. o kısımda da düzenleme yapıp gönderim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bb7hn Bir comment daha ekledim ama approve da ediyorum.
PR stale oldugu icin kapatiyorum bunu #589 |
Created types for new extra_parameters field. parsed checked and redirected url. If cannot parse or values are invalid alerted a message