-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all of the temperature model scripts into the main package #44
Conversation
…e version since there is no other package to speak of.
…r individual models
A built version of the docs is here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 6 files in question look ok to me.
Before you merge this, I would like to know how to update Ska tests, so I can update them quickly. Tests are currently defined in the
These tests are run:
Since these tests take some time to run, I think it is best if you help to determine exactly how we run them, so you also benefit from these extra test runs. Could this save you time in the long run? Would you benefit if these tests are run at other times? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@javierggt with this update, all of the tests you mentioned above would now be run from the |
Checked the "Support eclipses", "Fixing some bugs" and "Doc updates". All still looks good. |
Description
This PR moves all of the individual thermal model tools which depend on
acis_thermal_check
, such asdea_check
,acisfp_check
, etc., which currently reside in their own packages and github repositories.This looks incredibly daunting--~over 300 changed files! But most of them are the files which have been added in (scripts, tests, answers) as a result of moving the scripts in. The essential files to review are
main.py
,state_builder.py
,utils.py
,index_template.rst
,regression_testing.py
, andsetup.py
.This PR also makes the other changes:
get_xija_model_spec
to get the model specification fileThe regression tests which originally resided in the separate packages all passed after moving them to the new package, with minor modifications to the code (changing paths, etc.) but no changes to test answers were necessary. At the end of the development process, when eclipse states were added, this required an update to the test answers. The changes to the test answers were examined and consistent with the adding of eclipses.
A test run of the ACIS "LR" software confirmed that the executable path will not need to be changed once the new
acis_thermal_check
package is installed.After the new version of acis_thermal_check is installed in ska, we will need to uninstall the old packages (
dpa_check
, etc.). I will work with @javierggt , @taldcroft, and @jeanconn to figure this out.Testing