-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor doc updates #57
Conversation
I figured the best way to review would be for me to try running all the examples on the page, logged in as myself. I don't know ska at all, so if I can use the documentation to run the thermal models, that means the documentation is pretty good. I'm just checking that the examples ran to completion, and that the expected files were produced. I made no attempt to verify the validity of anything. (ska) luke-v-116: dpa_check --run-start=2019:300:12:50:00 --outdir=validate_dec2019 acis_thermal_check: [INFO ] ACISThermalCheck is using the 'acis' state builder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setups worked for me OK but I hit the same error as Catherine when running. Looks like the plots got generated ok though.
Thanks @jazan12 and @cegrant--that's a feature basically no one uses and there isn't a test for it, but it should be fixed (and a test added). Not related to the docs PR, I'll open a second one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Description
This PR updates the documentation for
acis_thermal_check
with two changes.Interface impacts
New docs build currently at https://cxc.cfa.harvard.edu/acis/acis_thermal_check.
New setup instructions at https://cxc.cfa.harvard.edu/acis/acis_thermal_check/running_models.html#where-to-run-the-models-from
Testing
None necessary.