Use explicit time units in time delta #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jzuhone - we'd like to get this into ska3-prime so we get clean pytest runs. |
|
And beyond just testing, this warning will show up on console every time you run an ACIS thermal checker. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ska3-prime with astropy 5.2, doing something like
CxoTime("2020:001") + 7generates a warning. The7should now be explicitly labeled as days via7 * u.daywithimport astropy.units as u.See sot/skare3#1055.
This fixes the warning in this package by using an explicit unit for a time arithmetic operation.
Interface impacts
None
Testing
Unit tests
kadyusing ska3-prime Python 3.10)Independent check of unit tests by [REVIEWER NAME]
Functional tests
Just to be sure, I ran tests to raise an exception for the warning in question.