Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ruff and black linting #66

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fixing ruff and black linting #66

merged 3 commits into from
Oct 25, 2023

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Oct 19, 2023

Description

This PR cleans up the code that handles linting and adopts a limited set of ruff rules that is used by other Ska packages, so that the linting tests pass and that the set of checks we perform is small in number and reasonable. There are no content changes here.

Interface impacts

None

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Functional tests

No functional testing.

@jzuhone jzuhone changed the title Fixing ruff and black lining Fixing ruff and black linting Oct 23, 2023
Copy link

@jazan12 jazan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked fine to me!

Copy link
Contributor

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jzuhone jzuhone merged commit ebefc28 into master Oct 25, 2023
1 check passed
@javierggt javierggt mentioned this pull request Jan 11, 2024
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants