Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thermal limits from JSON files, support ACIS FP in SimulateECSRun, new "attitude" argument #10

Merged
merged 13 commits into from
Jan 27, 2022

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jan 7, 2022

This PR uses the thermal limits from the JSON files in ThermalModelRunner, as well as a number of other items:

  • The model specification attribute of the ThermalModelRunner class should always be a dict--so let xija handle it first before making it an attribute
  • Add functionality for the ACIS FP temperature to SimulateECSRun check to see how much of the measurement will be "cold" and what temperature it reaches.
  • Every possible option for inputting spacecraft attitude into SimulateECSRun is now boiled down to a single "attitude" parameter. Options are:
    • (pitch, off nominal roll) tuple (constant state)
    • attitude quaternion (constant state)
    • load name (for ECS runs during vehicle-only loads)
  • A new test for the new ACIS FP functionality in SimulateECSRun was added.
  • Various doc fixes

Hard dependence on acisops/acis_thermal_check#45, soft dependence on sot/xijafit#14.

Tests in the ACISpy test suite pass.

@jzuhone jzuhone merged commit 49fc73c into acisops:master Jan 27, 2022
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant