Use thermal limits from JSON files, support ACIS FP in SimulateECSRun, new "attitude" argument #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the thermal limits from the JSON files in
ThermalModelRunner
, as well as a number of other items:ThermalModelRunner
class should always be a dict--so let xija handle it first before making it an attributeSimulateECSRun
check to see how much of the measurement will be "cold" and what temperature it reaches.SimulateECSRun
is now boiled down to a single "attitude" parameter. Options are:SimulateECSRun
was added.Hard dependence on acisops/acis_thermal_check#45, soft dependence on sot/xijafit#14.
Tests in the ACISpy test suite pass.