Fix ECS timing, silence Matplotlib warnings, code cleanup

[jzuhone]

Description

This PR addresses the following issues.

• The ACIS long ECS commanding no longer waits an extra 10012 seconds past the end of the ECS run to enable RADMON, so we remove that time from the SimulateECSRun calculation.
• In DatePlot and CustomDatePlot, no longer use the fmt keyword to avoid warnings from Ska.Matplotlib such as these:

/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/Ska/Matplotlib/core.py: UserWarning: linestyle is redundantly defined by the 'linestyle' keyword argument and the fmt string "-b" (-> linestyle='-'). The keyword argument will take precedence.
 ax.plot(dates, y, *args, **kwargs)
/data/acis/miniconda3/envs/ska/lib/python3.8/site-packages/Ska/Matplotlib/core.py: UserWarning: color is redundantly defined by the 'color' keyword argument and the fmt string "-b" (-> color='b'). The keyword argument will take precedence.
 ax.plot(dates, y, *args, **kwargs)

• Remove unnecessary subclassing of object
• Add a new set_yscale method to DatePlot and CustomDatePlot
• Use static model JSON files in the thermal model testing suite to get consistent answers

Interface impacts

None except the above.

Testing

Unit tests

• No unit tests
• Mac
• Linux
• Windows

Functional tests

A number of ACIS-related cron jobs which run various tasks depend on ACISpy for a range of functionality, these have run without issue on a test install of this PR. More importantly, the Matplotlib warnings went away.

[Gregg140]

Looks fine

[jazan12]

Hi John,

This looks fine. The only minor thing I wanted to double-check is I thought we were back to -88 as the perigee FP planning limit until matlab tools were updated. (Probably the model update already went in and I just don't remember, but in any case want to confirm. Assuming that's the case, all good by me.)

[jzuhone]

Hi @jazan12, the model file update here is just a JSON file for testing, so strictly speaking we don't need the limit to be -88 C here, especially since it is going back. But thanks for pointing that out.