Use chandra_limits to obtain limits, fix failing tests due to other ska updates #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
chandra_limits
package is now operational. There is a functionget_acis_limits
that now no longer exists inacis_thermal_check
, which was being used inacispy
to obtain limits for theSimulateECSRun
class. The fact that this function no longer exists was causingImportError
s.This PR removes the faulty import and fixes
SimulateECSRun
to use the newchandra_limits
way of obtaining the limits.Two other tests were failing because of recent updates to kadi, which resulted in very small changes to temperature predictions. These predictions have been updated since the reason is known. Another test was failing due to a change in xija, and it has been updated to pass.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Ran a few instances of
SimulateECSRun
to make sure it ran correctly.