Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include measured score in failure message #26

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 29, 2021

Fixes #14

@G-Rath G-Rath added the enhancement New feature or request label May 29, 2021
@G-Rath G-Rath requested a review from joshmcarthur May 29, 2021 07:11
@G-Rath
Copy link
Contributor Author

G-Rath commented May 29, 2021

(it'd be good to have #23 actioned before merging this, just so that releasing it taken care of automatically)

Copy link
Contributor

@joshmcarthur joshmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it has reinforced my belief that we need to do some work around the responsibilities the audit service has so that it's eaiser to access these score results without rerunning the audit.

@G-Rath G-Rath mentioned this pull request Aug 30, 2022
@robotdana
Copy link
Contributor

i think i'll merge #32 in favour of this unless you have a strong attachment to it, it only runs the audit once

@robotdana robotdana closed this Oct 21, 2022
@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 21, 2022

I'm not super fussed, other than to point out we could have landed this one as-is then tackled the "run audit once" in another PR since that'll require more review and #32 is currently failing CI, but we know we want this change either way (there's no harm in doing multiple releases either)

@G-Rath G-Rath deleted the include-measured-score-in-spec-message branch October 21, 2022 01:23
@G-Rath G-Rath restored the include-measured-score-in-spec-message branch August 27, 2023 00:15
@G-Rath G-Rath reopened this Aug 27, 2023
@G-Rath G-Rath force-pushed the include-measured-score-in-spec-message branch 2 times, most recently from 83ed983 to f0cd407 Compare August 27, 2023 01:21
@G-Rath G-Rath force-pushed the include-measured-score-in-spec-message branch from f0cd407 to 8a493ce Compare August 27, 2023 01:24
@G-Rath G-Rath merged commit a779421 into main Aug 27, 2023
5 checks passed
@G-Rath G-Rath deleted the include-measured-score-in-spec-message branch August 27, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output score in test results
3 participants