Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 7.1 #500

Closed
G-Rath opened this issue Oct 5, 2023 · 2 comments · Fixed by #502
Closed

Support Rails 7.1 #500

G-Rath opened this issue Oct 5, 2023 · 2 comments · Fixed by #502
Labels
enhancement New feature or request high-priority

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Oct 5, 2023

https://rubyonrails.org/2023/10/5/Rails-7-1-0-has-been-released
@G-Rath G-Rath added enhancement New feature or request high-priority labels Oct 5, 2023
@G-Rath

This comment was marked as resolved.

Sign in to view
@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 5, 2023

Blocked by Bullet:

Bullet does not support active_record 7.1.0 yet

@G-Rath G-Rath mentioned this issue Oct 5, 2023
Merged
6 tasks
lukeify pushed a commit that referenced this issue Nov 16, 2023
@G-Rath @eoinkelly
feat: support Rails 7.1 (#502)
62446f3 
Resolves #500 

This aims to be the minimal changes required for the template to work
with Rails 7.1

### Things which are not in scope for this PR

* Rails now generates docker related files - I've forced/skipped those
because their docker is focused on production and the diff is quite
large so I think it's best to tackle that as its own separate thing

### TODO
- [x] Do the basic upgrade
- [x] Adjust `frontend-base` to account for Shakapacker now doing a
thing we previously did ourselves.
- [x] `Rack::Handler is deprecated and replaced by Rackup::Handler`
warning. This appears during system tests. It is a knownw [Capybara
issue which is fixed but waiting on a gem
release](teamcapybara/capybara#2706). Since this
is just a warning and will go away in due course, we can ignore it.
- [x] Resolve `Setting 'useContentHash' to 'false' in the production
environment (specified by NODE_ENV environment variable) is not allowed!
Content hashes get added to the filenames regardless of setting
useContentHash in 'shakapacker.yml' to false.` warning. This warning
seems to caused by the default `shakapacker.yml`. Shakapacker generates
a `shakapacker.yml` file where `useContentHash: false` is set in the
`&default` section and then `useContentHash: true` is explicitly set in
the production section. It doesn't seem like a real problem so I think
we can ignore this.
- [x] Make a decision about #507 and implement it here 
    - We have decided to leave this option commented out for now.
- [ ] Make a decision about how to handle the
`Rails.application.secrets` deprecation because it will be removed in
7.2. #341 has good
context on the last time we discussed this.

---------

Co-authored-by: Eoin Kelly <eoin@eoinkelly.info>
Co-authored-by: Eoin Kelly <eoin.kelly@ackama.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support Rails 7.1 ackama/rails-template
1 participant
@G-Rath