Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rubocop-capybara which is included in rubocop-rspec gem #435

Merged
merged 2 commits into from
May 18, 2023

Conversation

eoinkelly
Copy link
Contributor

We use Capybara all the time so this seems sensible. It also silences a warning from rubocop when you run it in the generated apps:

The following RuboCop extension libraries are installed but not loaded in config:
  * rubocop-capybara

You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
  AllCops:
    SuggestExtensions: false

Rubocop output complains about this not being loaded. We use Capybara on
every app so enabling these cops seems sensible.
Bundler automatically added this on my Mac M1 Pro. Having it checked in
should avoid other Mx users from seeing this diff in future.
@eoinkelly eoinkelly requested a review from a team May 5, 2023 20:43
@@ -47,6 +47,7 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler auto-generated this on my M1 Pro. Checking it in so that we don't see this diff again in future from other M1 users.

@robotdana robotdana merged commit 3ae6260 into main May 18, 2023
21 checks passed
@robotdana robotdana deleted the update-rubocop-config branch May 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants