Add guzzle failure detector #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-claras
approved these changes
Nov 7, 2022
| * @test | ||
| * @vcr guzzle_responses.yml | ||
| */ | ||
| public function failureDetectorControlsIfResponseIsFailure() |
There was a problem hiding this comment.
Maybe add a second test with isFailureResponse returning false?
There was a problem hiding this comment.
Good point. 💡 I think it's okay to not have the second test case since AlwaysSuccessFailureDetector, which returns false is used as default.
ackintosh
approved these changes
Jan 5, 2023
|
This enhancement has been released in v3.1.0! Thank you for your contribution @e-zannelli . 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We would like to be able to control what is considered a failure.
So here is a very simple implementation of a FailureDetector inspired by what was done for HttpClient.
What do you think?
Thanks.