Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward incompatibility in v1.2.1 #81

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

ackintosh
Copy link
Owner

@ackintosh ackintosh commented Dec 15, 2020

related issue: #80

This fix is to ease the backward incompatibility in 1.2.1.

Unfortunately this does not completely fix the incompatibility. If you are using your custom adapter, please add setContext method like below in order to keep behaviors of your adapter.

If your custom adapter extends a built in adapter like below, it is recommended to use the parent implementation:

class CustomAdapter extends \Ackintosh\Ganesha\Storage\Adapter\Memcached
{
    // Comment out to use the parent implementation
    // public function setContext(Ganesha\Context $context): void
    // {
    // }
}

or if your custom adapter using no built in adapter, please add an empty setContext method to satisfy AdapterInterface requirement.

class CustomAdapter implements \Ackintosh\Ganesha\Storage\AdapterInterface
{
    public function setContext(Ganesha\Context $context): void
    {
         // nop
    }
}

@coveralls
Copy link

coveralls commented Dec 15, 2020

Coverage Status

Coverage decreased (-0.3%) to 91.736% when pulling 7abb09a on fix-backward-incompatibility into a225863 on master.

@ackintosh ackintosh merged commit a9e0d4f into master Dec 17, 2020
@ackintosh ackintosh deleted the fix-backward-incompatibility branch December 19, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants