Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PHP7.1, 7.2 and Add PHP 8.0 #83

Merged
merged 5 commits into from
Jun 19, 2021
Merged

Drop PHP7.1, 7.2 and Add PHP 8.0 #83

merged 5 commits into from
Jun 19, 2021

Conversation

ackintosh
Copy link
Owner

@ackintosh ackintosh commented Mar 30, 2021 •
edited
Loading

closes #76

TODO

  • Drop PHP7.1 and PHP7.2 support
  • Bump up the PHPUnit version ("phpunit/phpunit": "^9.5.4" )
  • Enable CI on PHP8

@ackintosh ackintosh changed the title Drop PHP7.1 and PHP7.2 support Drop PHP7.1, 7.2 and Add PHP 8.0 Jun 13, 2021
@ackintosh
Copy link
Owner Author

https://github.com/ackintosh/ganesha/pull/83/checks?check_run_id=2813789369

Problem 1

  • Root composer.json requires php-vcr/phpunit-testlistener-vcr ~3.2.1 -> satisfiable by php-vcr/phpunit-testlistener-vcr[3.2.1].
  • php-vcr/phpunit-testlistener-vcr 3.2.1 requires php ^7.1 -> your php version (8.0.7) does not satisfy that requirement.

Hmm... phpunit-testlistener-vcr seems not active but fortunately we could use the feature branch kornrunner:php8 instead. 👀
php-vcr/phpunit-testlistener-vcr#38

@ackintosh ackintosh marked this pull request as ready for review June 19, 2021 23:30
@ackintosh ackintosh merged commit 5ec6567 into master Jun 19, 2021
@ackintosh ackintosh deleted the drop-php71-php72 branch June 19, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop PHP7.1 and 7.2 support
1 participant
@ackintosh