RedisStore use ClientInterface instead of Client #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed RedisStore te accept ClientInterface instead of Client so we are not locked to the the default implementation Added tests for when we pass ClientInterface instead of a Client
ackintosh
reviewed
Apr 26, 2022
There was a problem hiding this comment.
@fhjbalfoort Thank you for your PR. This looks great to me!
Although the code style check in CI has passed, I've left a tiny suggestion.
| @@ -178,7 +178,7 @@ public function get(string $key) | |||
| { | |||
| try { | |||
| $result = $this->redis->get($key); | |||
| if ($this->redis instanceof \Predis\Client && $result === null) { | |||
| if ($this->redis instanceof \Predis\ClientInterface && $result === null) { | |||
There was a problem hiding this comment.
Suggested change
| if ($this->redis instanceof \Predis\ClientInterface && $result === null) { | |
| if ($this->redis instanceof \Predis\ClientInterface && $result === null) { |
There was a problem hiding this comment.
Thank you for reviewing and updated the MR with your suggestion
ackintosh
approved these changes
Apr 26, 2022
|
This pull request has been released as v2.0.2. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use RedisStore in combination with Predis. We wrap the default client with metric but RedisStore doesn't accept a ClientInterface so we are stuck with passing a Client.
I changed the RedisStore so that it will accept a ClientInterface instead of a Client