Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm types to public interfaces to guide static analysis. #99

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

mad-briller
Copy link
Contributor

Some comment additions that will help Ganesha users that use static analysis provide correct values when configuring.

Also removed 1 or 2 superfluous use statements i noticed aswell.

@coveralls
Copy link

coveralls commented Sep 19, 2022

Coverage Status

Coverage remained the same at 92.514% when pulling 7c50fab on mad-briller:add.psalm-types into 3e6247e on ackintosh:master.

Copy link
Owner

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@ackintosh ackintosh merged commit 68792cb into ackintosh:master Sep 21, 2022
@ackintosh
Copy link
Owner

@mad-briller This PR has been released as v3.0.1! Thank you for your contribution. 🎉
https://github.com/ackintosh/ganesha/releases/tag/3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants