Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code to Swift 3 #6

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Migrate code to Swift 3 #6

wants to merge 23 commits into from

Commits on Mar 5, 2017

  1. Upgrade to Swift 3

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    c111f00 View commit details
    Browse the repository at this point in the history

  2. Solve warning: use Quality of Service since "priority" is deprecated

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    b7d02ba View commit details
    Browse the repository at this point in the history

  3. add gitignore, commit modified podfile

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    54db5fd View commit details
    Browse the repository at this point in the history

  4. commit Alamofire pod

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    79b0b33 View commit details
    Browse the repository at this point in the history

  5. add some xcode setting ignores, from https://github.com/github/gitign… 

    …ore/blob/master/Objective-C.gitignore
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    bea310b View commit details
    Browse the repository at this point in the history

  6. Constrain collection view to always fit screen

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    acfcfcf View commit details
    Browse the repository at this point in the history

  7. Add constraints to stock list search view to maintain responsiveness

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    0b1709c View commit details
    Browse the repository at this point in the history

  8. fix some conflicting auto layout constraints

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    208103a View commit details
    Browse the repository at this point in the history

  9. Revert "fix some conflicting auto layout constraints" 

    This reverts commit 208103a.
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    5e9f659 View commit details
    Browse the repository at this point in the history

  10. put back constraint that was an IBOutlet. confirm everything's workin… 

    …g on an actual iPhone device / no crashing run time errors
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    fd17f4f View commit details
    Browse the repository at this point in the history

  11. start trying to debug why chartView isn't responsive

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    c7876b9 View commit details
    Browse the repository at this point in the history

  12. open up other xibs

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    5bdd84a View commit details
    Browse the repository at this point in the history

  13. Merge branch 'swift3' into swift3-dev

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    2211aa4 View commit details
    Browse the repository at this point in the history

  14. programmatic constraints make the alignment of the chartView, and cha… 

    …rt, responsive. Though drawing of the "chart" itself still isn't responsive
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    d451a80 View commit details
    Browse the repository at this point in the history

  15. price chart is properly responsive (e.g. to screen rotations, differe… 

    …nt sized screens)
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    a2b3cad View commit details
    Browse the repository at this point in the history

  16. remove debug background coloring

    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    4ad3317 View commit details
    Browse the repository at this point in the history

  17. Revert "remove debug background coloring" 

    This reverts commit 4ad3317.
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    2c1ae2f View commit details
    Browse the repository at this point in the history

  18. give price chart a little bit more of a buffer, add NSLayoutConstrain… 

    …t extension to speed build, due to a bug in swift
    @troyshu
    troyshu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    efc1ca2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2017

  1. comment out view debug background colors

    @troyshu
    troyshu committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    c1dc141 View commit details
    Browse the repository at this point in the history

  2. time range select buttons for price chart are now properly centered

    @troyshu
    troyshu committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    6f564da View commit details
    Browse the repository at this point in the history

  3. add code to control date range buttons like radio buttons. change dep… 

    …loyment target to iOS 9+ (because of UIStackView)
    @troyshu
    troyshu committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    fb7cbdd View commit details
    Browse the repository at this point in the history

  4. select default time range button when rotate, because chart re-draws … 

    …to default time range
    @troyshu
    troyshu committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    1c75af4 View commit details
    Browse the repository at this point in the history

  5. programmatically style selected/unselected date range radio buttons. … 

    …improve their spacing too
    @troyshu
    troyshu committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    4e46b8d View commit details
    Browse the repository at this point in the history