Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/opt/vdhcoapp/vdhcoapp install does not create net.downloadhelper.coapp.json for flatpak-installed Edge despite linking itself in its sandbox #207

Closed
norweeg opened this issue Jan 23, 2024 · 4 comments

Comments

@norweeg
Copy link

norweeg commented Jan 23, 2024

Similar to #131 , running /opt/vdhcoapp/vdhcoapp install will detect flatpak, link itself in all browser sandboxes (including flatpak-installed Google Chrome and Microsoft Edge), but it only creates ~/.var/app/com.google.Chrome/config/google-chrome/NativeMessagingHosts/net.downloadhelper.coapp.json but not the corresponding ~/.var/app/com.microsoft.Edge/config/microsoft-edge/NativeMessagingHosts/net.downloadhelper.coapp.json even though ~/.var/app/com.google.Chrome/config/google-chrome/NativeMessagingHosts/net.downloadhelper.coapp.json contains the correct allowed origin for the Edge Extension store version of the VDH extension.

@paulrouget
Copy link
Member

If you copy ~/.var/app/com.google.Chrome/config/google-chrome/NativeMessagingHosts/net.downloadhelper.coapp.json to ~/.var/app/com.microsoft.Edge/config/microsoft-edge/NativeMessagingHosts/net.downloadhelper.coapp.json , does it work?

@paulrouget
Copy link
Member

paulrouget commented Jan 24, 2024

For some reasons, we do not create that file. Indeed.

Can you confirm copying the file works? And I'll do a new release.

And thank you for helping out!

@norweeg
Copy link
Author

norweeg commented Jan 25, 2024

If you copy ~/.var/app/com.google.Chrome/config/google-chrome/NativeMessagingHosts/net.downloadhelper.coapp.json to ~/.var/app/com.microsoft.Edge/config/microsoft-edge/NativeMessagingHosts/net.downloadhelper.coapp.json , does it work?

yes, it does and that's what I did before reporting the bug since it just seemed like it was just overlooked because you link the vdhcoapp to the Edge sandbox (and other Chromium-based browsers) AND include the correct allowed origin in the net.downloadhelper.coapp.json installed for Chrome, but then not install the same file for Edge (and apparently Ungoogled-Chromium and likely none of the other Chromium-based browsers whose sandbox it was linked to either)

@paulrouget
Copy link
Member

@norweeg thanks for your help.

This will be fixed in CoApp 2.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants