This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Implement test cases #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 10, 2016 22:49
Get the latest update
hugovk
suggested changes
Oct 11, 2016
| @@ -7,48 +7,28 @@ class testNormalize(unittest.TestCase): | |||
| """ | |||
| A test class for the normalize method. | |||
| """ | |||
| def testFakePackage(self): | |||
|
|
|||
| def test_FakePackage(self): | |||
|
|
||
| def testDjango(self): | ||
| def test_Django(self): |
| normalized = vanity.normalize("dJaNgO") | ||
| self.assertEqual(normalized, "Django") | ||
|
|
||
| def testNone(self): | ||
| def test_None(self): |
| normalized = vanity.normalize(None) | ||
| self.assertEqual(normalized, "none") | ||
|
|
||
| def testFlask(self): | ||
| def test_Flask(self): |
| normalized = vanity.normalize("fLaSk") | ||
| self.assertEqual(normalized, "Flask") | ||
|
|
||
| def testSpaceString(self): | ||
| def test_SpaceString(self): |
| normalized = vanity.normalize(None) | ||
| self.assertEqual(normalized, "none") | ||
|
|
||
| def test_Flask(self): |
| normalized = vanity.normalize("fLaSk") | ||
| self.assertEqual(normalized, "Flask") | ||
|
|
||
| def test_SpaceString(self): |
| def test_SpaceString(self): | ||
| normalized = vanity.normalize(" Flask ") | ||
| self.assertEqual(normalized, " Flask ") | ||
|
|
||
| def testEmpty(self): |
| normalized = vanity.normalize(" Flask ") | ||
| self.assertEqual(normalized, " Flask ") | ||
|
|
||
| def test_Empty(self): |
| normalized = vanity.normalize(None) | ||
| self.assertEqual(normalized, "none") | ||
|
|
||
| def testEmpty(self): | ||
| def test_Flask(self): |
added 2 commits
October 11, 2016 01:41
|
Should I also rename the class name to test_Normalize for consistency? |
|
@killvung Yes please. |
|
I actually changed it while asking for it |
|
And please lowercase it for consistency too. Thank you! |
|
Done |
hugovk
approved these changes
Oct 11, 2016
|
I squashed this into a single commit and merged. Thanks! |
|
Thank you so much |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the white spaces problem, I am using Sublime without any plugins, so I don't realized the existence of them.
Also I had fixed some of the problems @hugovk mentioned