Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const qualifier from setter #54

Closed
wants to merge 1 commit into from

Conversation

Smertig
Copy link

@Smertig Smertig commented Sep 6, 2020

This is just a typo fix. Fixes #44

clang-10 refuses to compile library:

.../libelfin/elf/data.hh:558:22: error: cannot assign to non-static data member within const member function 'set_binding'
                info = (info & 0xF) | ((unsigned char)v << 4);
                ~~~~ ^
.../libelfin/elf/data.hh:556:14: note: member function 'elf::Sym<elf::Elf64, Order>::set_binding' is declared const here
        void set_binding(stb v) const
        ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

@emeryberger
Copy link
Contributor

Fixed with #79.

@Smertig Smertig closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failure with LLVM 10
2 participants