Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support omitting end tags for encoding SGML #1

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Support omitting end tags for encoding SGML #1

merged 1 commit into from
Jun 14, 2019

Conversation

JohnStarich
Copy link
Contributor

Addresses part of aclindsa/ofxgo#18

JohnStarich
JohnStarich commented Jun 14, 2019
View reviewed changes
go.mod Show resolved Hide resolved
@JohnStarich JohnStarich mentioned this pull request Jun 14, 2019
Closed
aclindsa
aclindsa approved these changes Jun 14, 2019
View reviewed changes
Copy link
Owner

@aclindsa aclindsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for your work on this so far and for taking the time to do it right (for example, the tests) - it shows.

marshal_test.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@aclindsa aclindsa merged commit 564dc70 into aclindsa:master Jun 14, 2019
@JohnStarich JohnStarich deleted the feature/encode-sgml branch June 15, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclindsa aclindsa aclindsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnStarich @aclindsa