Check for non-empty event buffer on perfhup #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if poll returned HUP, we would immediately return ErrDisabled, but this means we could miss events if there are events waiting in the buffer. Fixes: acln0#23
Closed
|
Please consider this patch carefully. I'm still not certain that this fixes all the underlying issues. I'll let you think about it before explaining what I understand, so that we each cover as much ground as possible :) |
This was referenced May 10, 2020
|
Friendly ping. My memory of this is fading. I spent a fair amount of time trying to understand this at the time, and concluded this was the right thing to do. Without it, I recall seeing events missing from the ring buffer. |
|
Ping @acln0 |
|
Ping, it would be nice to try and resolve this some time. Hope all is well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if poll returned HUP, we would immediately return ErrDisabled, but
this means we could miss events if there are events waiting in the buffer.
Fixes: #23